Comments left on individual commits in a PR can't be found
If someone comments on a specific commit in a PR, the comments don't appear in the PR feed or the latest "Files" view of the file.
Add Comment
Thank you for your feedback. This is a known limitation today, we are working on closing this gap soon in a future upcoming release. Thank you for helping us build a better Visual Studio.
I run into this issue a lot, as I tend to click through commit history in large PRs to see the code in more easily digested chunks.
do you have an ETA on this work? :)
I hit this twice yesterday. When a new commit is pushed to a PR I had previously reviewed, I want to review the new changes specifically. I do that by inspecting the commit. Those comments not showing up on the PR is unexpected and a significant disruption to the work flow.
Any progress on this front would be highly appreciated :)
My team just ran into this as well and wouldn't have noticed if we hadn't chatted offline about the commit. This can be especially troublesome where a reviewer performs a "Approve with suggestions" but the submitter is unaware of the comments/suggestions.
We also missing these comments on the commits itself:
In the Pull request overview I find it hard to find all the comments on commits. That’s because the Overview Tab only shows all comments on files and not the comments on the commits themselves. Furthermore the Commits Tab does not indicate which commit have comments (via an icon or something). Which used to be the case on earlier versions. I would suggest adding an icon to indicate which commits have comments and which not or another way to get a clear overview of all the comments on the commits within a pull request.
Maybe post it on the UserVoice...?
Sorry for the issues you are having with commit comments. There is some confusing behavior related to commits, as alluded to above. If you make a comment on the commits page (URL is "/rep/commit/<guid>), it will not show up in the context of the PR in any tab. You should still see the comment in the file tree on the commit view itself. On the PR page (/repo/pullrequest/<id>) you will only see comments left on the PR. They should also show up in the file tree.
If you are not seeing the behavior I describe, then there might be a regression that we can follow up on (can you post scenario details below my comment so we can dig in more?). If you are talking specifically about comments left on commits, then I definitely suggestion you post it on uservoice since that is typically how we decide what we need to work on next in the pull request area.
Thanks, Ross. Looks like this is already on UserVoice -- I've upvoted. Would be great to see this added, as commit-by-commit review is a fundamental workflow.
To more accurately capture the status of this item, we're changing the status to Closed - Suggestion. As has been pointed out, there is a UserVoice issue where others have already suggested the same improvement to improve the per-commit commenting experience in VSTS PRs. We suggest that anyone interested in us investing in this area please upvote that item: https://visualstudio.uservoice.com/forums/330519-visual-studio-team-services/suggestions/12354291-comments-in-a-commit-should-show-up-in-the-pull-re Thanks!
Will this item be considered for re-opening with the closing of UserVoice?
this is a great question, the user voice item will be migrated and that will be the workitem tracking this work - https://blogs.msdn.microsoft.com/devops/2018/10/26/azure-devops-feature-suggestions/
